Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid to save file if it's not on latest revision #3124

Merged
merged 7 commits into from
Oct 10, 2022
Merged

Forbid to save file if it's not on latest revision #3124

merged 7 commits into from
Oct 10, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Oct 6, 2022 •
edited
Loading

@codecov
Copy link

codecov bot commented Oct 6, 2022 •
edited
Loading

Codecov Report

Merging #3124 (3441ebf) into master (edf30b0) will increase coverage by 0.31%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3124      +/-   ##
==========================================
+ Coverage   35.05%   35.37%   +0.31%     
==========================================
  Files         647      649       +2     
  Lines       28482    28645     +163     
  Branches     4187     4186       -1     
==========================================
+ Hits         9985    10132     +147     
- Misses      17317    17334      +17     
+ Partials     1180     1179       -1
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog 8.37% <0.00%> (-0.01%) ⬇️
lambda 86.05% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/FileEditor/loader.ts 58.53% <0.00%> (-4.63%) ⬇️
catalog/app/containers/Bucket/File.js 0.00% <0.00%> (ø)
lambdas/access_counts/tests/test_access_counts.py 100.00% <0.00%> (ø)
lambdas/access_counts/index.py 86.36% <0.00%> (ø)
lambdas/shared/t4_lambda_shared/utils.py 97.40% <0.00%> (+2.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 October 6, 2022 14:40
nl0
nl0 previously approved these changes Oct 7, 2022
View reviewed changes
@fiskus
Copy link
Member Author

fiskus commented Oct 10, 2022

@nl0 I renamed hash to fileVersionId. Please, approve once again if you don't mind

@fiskus fiskus merged commit 32ff2c2 into master Oct 10, 2022
@fiskus fiskus deleted the check-if-revision-is-outdated branch October 10, 2022 13:35
@fiskus fiskus mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nl0 nl0 nl0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiskus @nl0